feat: readd timeout info durations to InitChainer and EndBlocker#70
Merged
damiannolan merged 7 commits intosdk-v0.50.xfrom Apr 3, 2025
Merged
feat: readd timeout info durations to InitChainer and EndBlocker#70damiannolan merged 7 commits intosdk-v0.50.xfrom
damiannolan merged 7 commits intosdk-v0.50.xfrom
Conversation
damiannolan
commented
Mar 20, 2025
Author
|
This needs to override the |
damiannolan
commented
Apr 2, 2025
|
|
||
| // Info implements the abci interface. It overrides baseapp's Info method, essentially becoming a decorator | ||
| // in order to assign TimeoutInfo values in the response. | ||
| func (app *App) Info(req *abci.RequestInfo) (*abci.ResponseInfo, error) { |
Author
There was a problem hiding this comment.
@julienrbrt can you confirm that any of the old diffs from here aren't needed anymore? https://github.com/celestiaorg/celestia-app/blob/main/app/app.go#L558
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readd CIP-26 for timeout info.